-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BugFix - 42091 - Added check for 0,0 Viewport Size #3882
BugFix - 42091 - Added check for 0,0 Viewport Size #3882
Conversation
WalkthroughThe changes in the code involve adjustments to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PlaywrightDriver
User->>PlaywrightDriver: ChangeAppWindowSize(width, height)
alt Valid dimensions
PlaywrightDriver->>PlaywrightDriver: Adjust window size
else Invalid dimensions (<= 0)
PlaywrightDriver->>User: Return early, ignore request
end
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- Ginger/GingerCoreNET/Drivers/CoreDrivers/Web/Playwright/PlaywrightDriver.cs (2 hunks)
Additional comments not posted (2)
Ginger/GingerCoreNET/Drivers/CoreDrivers/Web/Playwright/PlaywrightDriver.cs (2)
490-491
: LGTM!The indentation change improves readability without altering functionality.
The code changes are approved.
1577-1581
: LGTM!The new check ensures that the method returns early if the provided
width
orheight
is less than or equal to zero, preventing issues with zero dimensions.The code changes are approved.
Thank you for your contribution.
Before submitting this PR, please make sure:
Summary by CodeRabbit
Bug Fixes
ChangeAppWindowSize
method to prevent issues when invalid width or height values are provided, improving stability during window size adjustments.Style
ThrowIfClosed
method.